allow function block accept the same format as function set & block_state
#1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17183248569
force-pushed
the
blockvalue
branch
from
86144e3 to
a328da1
Compare
17183248569
force-pushed
the
blockvalue
branch
from
3f9ceb7 to
e3d11f7
Compare
|
emmmm.....git conflit.......😟 maybe i should do that tomorrow..... |
|
😀 I finally fix the git conflit...... now i need to check if the "set" function works as it used to be. |
seems fine now
gnembon
reviewed
Oct 16, 2023
gnembon
reviewed
Oct 16, 2023
gnembon
reviewed
Oct 16, 2023
|
ok. i have fixed all the things you mentioned above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i copy some code from function
setso that it can use the same format as set too.the format is used in return value of
block_state()too.eg:
block('iron_trapdoor',{'half'->'top'},nbt)that is to avoid some unnecessary changing maps into string. (then it need to turn back inside the function)