Fix error handling the case where a cookie is not parseable ... in ne…

…eds to be removed from the array.
gnustep · Dec 23, 2024 · e7716e6 · e7716e6
1 parent 34112fa
commit e7716e6
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/Source/NSHTTPCookie.m b/Source/NSHTTPCookie.m
@@ -161,7 +161,7 @@ + (NSMutableArray *) _parseField: (NSString *)field
      dates and also could have tokens without values. */
   while (count-- > 0)
     {
-      NSHTTPCookie 		*cookie;
+      NSHTTPCookie 		*cookie = nil;
       NSMutableDictionary	*dict;
       NSString			*onecookie = [cookies objectAtIndex: count];
 
@@ -181,14 +181,14 @@ + (NSMutableArray *) _parseField: (NSString *)field
 	      [dict setObject: defaultDomain forKey: NSHTTPCookieDomain];
 	    }
 	  cookie = [NSHTTPCookie cookieWithProperties: dict];
-	  if (cookie)
-	    {
-	      [cookies replaceObjectAtIndex: count withObject: cookie];
-	    }
-	  else
-	    {
-	      [cookies removeObjectAtIndex: count];
-	    }
+	}
+      if (cookie)
+	{
+	  [cookies replaceObjectAtIndex: count withObject: cookie];
+	}
+      else
+	{
+	  [cookies removeObjectAtIndex: count];
 	}
     }
   return cookies;