Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSObject: Change return type of setVersion: from id to void #344

Merged
merged 1 commit into from
Nov 13, 2023
Merged

NSObject: Change return type of setVersion: from id to void #344

merged 1 commit into from
Nov 13, 2023

Conversation

hmelder
Copy link
Contributor

@hmelder hmelder commented Nov 11, 2023

I have check libs-base and found no code that expects a return value from setVersion:

As the GNUstep implementation diverges from Foundation, we treat this as a bug.

@hmelder hmelder requested a review from rfm as a code owner November 11, 2023 19:13
@hmelder hmelder mentioned this pull request Nov 11, 2023
Closed
rfm
rfm approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@rfm rfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks.

@hmelder
Copy link
Contributor Author

hmelder commented Nov 13, 2023 •
edited
Loading

CI error is unrelated:

Building base/NSNumber/test01.m
make test01
Making all for test_tool test01...
Compiling file test01.m ...
test01.m:28:38: error: use of undeclared identifier 'M_PI'
n = [NSNumber numberWithFloat: M_PI];

@hmelder hmelder merged commit a66d255 into master Nov 13, 2023
8 of 9 checks passed
@hmelder hmelder deleted the nsobject_setversion branch November 13, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfm rfm rfm approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmelder @rfm