fix SummarizeValues to return last non-NaN value #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could anybody take a look at this please? It is not the fault of this PR that the DeepSource test fails, it does not change the complexity of the SummarizeValues function. |
Civil
previously approved these changes
Dec 19, 2024
auto-merge was automatically disabled
December 19, 2024 19:58
Head branch was pushed to by a user without write access
|
Thanks @Civil. Unfortunately, I messed up the average part of SummarizeValues when I removed the unnecessary return path. I fixed that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
SummarizeValuesis called withlastorcurrentas the aggregation function, it returns the last value of the series, whether it is NaN or not. This causeslegendValueto output "NaN" in the legend, even if there are non-NaN values the series.This PR changes the behavior of
SummarizeValuesso that the last non-NaN value is returned.