Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set proper "content-type" while calling JwtService.Reset() #203

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

iRay
Copy link
Contributor

@iRay iRay commented Jun 17, 2024

During "LogOut", JwtService.Reset() doesn't set "content-type" header that leads to "XML Parsing Error: no root element found" in FireFox.
This PR simply adds proper header.

@iRay iRay requested a review from umputun as a code owner June 17, 2024 14:11
@paskal
Copy link
Collaborator

paskal commented Jun 18, 2024

@iRay, please copy the exact change to the v2 directory, as it will be released soon and will need those changes.

@iRay
Copy link
Contributor Author

iRay commented Jun 18, 2024

@paskal ok, got you, thx.

@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9549266452

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 82.758%

Totals Coverage Status
Change from base Build 8627959567: 0.01%
Covered Lines: 2563
Relevant Lines: 3097

💛 - Coveralls

@paskal
Copy link
Collaborator

paskal commented Jun 18, 2024

@iRay apologies for not being clear on that: could you please add the change both to v1 and v2?

@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9563737651

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 82.758%

Totals Coverage Status
Change from base Build 8627959567: 0.01%
Covered Lines: 2563
Relevant Lines: 3097

💛 - Coveralls

@iRay
Copy link
Contributor Author

iRay commented Jun 18, 2024

@paskal you was clear enough and I added the same changes to v2. Maybe I missed something else?

@coveralls
Copy link

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9563737652

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 82.758%

Totals Coverage Status
Change from base Build 8627959567: 0.01%
Covered Lines: 2563
Relevant Lines: 3097

💛 - Coveralls

@iRay
Copy link
Contributor Author

iRay commented Jun 18, 2024

@paskal you was clear enough and I added the same changes to v2. Maybe I missed something else?

Or maybe you meant I need to create another branch and new PR with changes for v1 and v2?

Copy link
Member

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@umputun umputun merged commit 733697d into go-pkgz:master Jun 18, 2024
6 checks passed
@iRay iRay deleted the fix-logout-empty-header branch June 18, 2024 20:24
@paskal
Copy link
Collaborator

paskal commented Jun 18, 2024

Now it's good, thank you!

@paskal
Copy link
Collaborator

paskal commented Sep 19, 2024

This commit caused issue umputun/remark42#1812. I think changing the context type to text/plain would fix the situation as we don't respond with any text and it's not a valid json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants