-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set proper "content-type" while calling JwtService.Reset() #203
Conversation
@iRay, please copy the exact change to the v2 directory, as it will be released soon and will need those changes. |
@paskal ok, got you, thx. |
Pull Request Test Coverage Report for Build 9549266452Details
💛 - Coveralls |
@iRay apologies for not being clear on that: could you please add the change both to v1 and v2? |
Pull Request Test Coverage Report for Build 9563737651Details
💛 - Coveralls |
@paskal you was clear enough and I added the same changes to v2. Maybe I missed something else? |
Pull Request Test Coverage Report for Build 9563737652Details
💛 - Coveralls |
Or maybe you meant I need to create another branch and new PR with changes for v1 and v2? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx
Now it's good, thank you! |
This commit caused issue umputun/remark42#1812. I think changing the context type to |
During "LogOut", JwtService.Reset() doesn't set "content-type" header that leads to "XML Parsing Error: no root element found" in FireFox.
This PR simply adds proper header.