Get more type information from runtime parser #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse/base.go
Outdated
| @@ -16,6 +16,27 @@ type FieldInfo struct { | |||
| Name string // field name as defined in source file, e.g. Name | |||
| Type string // field type as defined in source file, e.g. string; always present for primary key, may be absent otherwise | |||
| Column string // SQL database column name from "reform:" struct field tag, e.g. name | |||
|
|
|||
| // TODO Kind reflect.Kind // underlying type; set only by runtime parser | |||
There was a problem hiding this comment.
[Optional linters] reported by reviewdog 🐶
parse/base.go:20: Line contains TODO/BUG/FIXME: "TODO Kind reflect.Kind // underlying typ..." (godox)
AlekSi
force-pushed
the
get-more-data-from-runtime
branch
from
cb45cad to
aa23a08
Compare
Codecov Report
@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 68.08% 69.61% +1.53%
==========================================
Files 19 20 +1
Lines 1720 1787 +67
==========================================
+ Hits 1171 1244 +73
+ Misses 491 474 -17
- Partials 58 69 +11
Continue to review full report at Codecov.
|
AlekSi
force-pushed
the
get-more-data-from-runtime
branch
from
f73da84 to
d057d43
Compare
AlekSi
force-pushed
the
get-more-data-from-runtime
branch
from
d057d43 to
26cbc0c
Compare
AlekSi
changed the title
AlekSi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.