Add mutex support for Resty V3 #822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeevatkm
requested changes
Aug 18, 2024
There was a problem hiding this comment.
@tttturtle-russ For v3, you have to use branch main and create PR against branch main. For more info, refer to v3 dev notes - #720
For example: HostURL deprecation is already removed on the branch main.
|
Oh, I see. I will change to the main branch. |
|
I will close this PR and reopen a new PR based on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix #812. Add a RWMutex to
Clientand change replace every public property with an exported method. Meanwhile, to pass the retry test, I increase the maxRetryWaitTime to pass the test.