feat: implement yaml functions based on helm implementation #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42atomys
added
domain/obvious 🟩
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
|
Does this PR actually need sigs.k8s.io/yaml or rather gopkg.in/yaml.v3? Seems the dependency tree could be reduced a little but by removing k8s. |
6 tasks
42atomys
pushed a commit
that referenced
this pull request
Jun 16, 2024
## Description Noticed that k8s suddenly appeared in my dependencies. Since this only adds yaml2json features it's not necessary here. ## Changes - Replace sigs yaml deps by go-yaml ## Checklist - [x] I have read the **CONTRIBUTING.md** document. - [x] My code follows the code style of this project. - [x] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] I have updated the documentation accordingly. - [ ] This change requires a change to the documentation on the website. ## Additional Information Follow-up to #36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We continue to backport features, bug fixes, and more from Sprig to Sprout. This time, I'm focusing on the YAML functions part, used by Helm and intended for use by others as well.
Changes
fromYamlfunction to convert yaml string into a go maptoYamlfunction to convert any to a yaml stringmustFromYamlfunction to convert and return error to the template system when occursmustToYamlfunction to convert and return error to the template system when occursFixes Masterminds/sprig#358 Masterminds/sprig#360
Checklist
Additional Information
The documentation for the encoding part of the library will be released soon after this pull request on https://sprout.atom.codes
Initially implemented by @blakepettersson on sprig