-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement registry system (alias: loader) #46
Conversation
First self feedback: allow registry to register aliases with functions |
Second step :
|
95d6990
to
bc3fb90
Compare
Currently start the last step :
🎉 This pull request are done in case of functionalities and tests. This will be merged soon as the documentation are ready too |
Co-Authored-By: ccoVeille <[email protected]>
Co-Authored-By: ccoVeille <[email protected]>
Hi @ccoVeille, thanks for your contribution in reviewing this big PR 💜 According to multiple comments on the crypto package, this package was backported from sprig and will be dropped in a few versions due to significant security issues. I've been focusing on rewriting and enhancing other registries, so I haven't made any changes to this one. |
Co-Authored-By: ccoVeille <[email protected]>
Co-Authored-By: ccoVeille <[email protected]>
Old code is not funny. Noted |
it looks really good! I liked the registry idea, and the implementation looks good! lgtm! |
Thanks @ccoVeille and @caarlos0 for your time and your contribution to reviewing this next step of Sprout 🌱 💜 |
Description
Following the discussion about function loading in #31, this huge refactor implement each method behind multiples registries.
Warning
This pull request are in progress, somes tests must be done before allowing it to be merge and release. Each feedback are welcome !
TODO
Changes
FuncsMap
register all registry by defaultFixes #10
Checklist
Additional Information
This update following the discussions #31