feat: node refactor #1316
Merged
feat: node refactor #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is closely linked to #1152. In summary, I have pulled out the refactor changes that are a precursor to the remote Taskfile work. This is the stuff that continuously needs to be rebased as it conflicts with other areas of the codebase. Once this is merged, it should be significantly easier to work on #1152 without it conflicting with other changes.
This work includes the new
Nodeinterface which abstracts the logic for reading a Taskfile into various implementations (Just regular file reading for now). None of the changes here impact any of the outstanding decisions to be made in #1152 and can safely be merged without any changes to behaviour/functionality.