feat: add support for multiple includes on a graph edge #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1606
Allows someone to create multiple includes to/from the same Taskfiles. This was restricted when we moved to the DAG reader implementation. The DAG library we use does not support adding multiple edges between nodes. However, the problem is easily solved by changing the edge data from
*ast.Includeto[]*ast.Include. This also allows us to easily calculate the weight (number of connections) of any edge by calculating the length of the slice.I've also undone the changes to some of the tests that used to use multiple includes that were changed when the DAG reader was implemented.