fix: expand task-level dotenv in brackets #1627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
commented
May 3, 2024
Comment on lines
8
to
+19
| dotenv: ['.env'] | ||
| cmds: | ||
| - echo "$FOO" > dotenv.txt | ||
| - echo "{{.FOO}}" > dotenv-2.txt | ||
| - task: dotenv_called | ||
| vars: | ||
| FOO: "{{.FOO}}" | ||
|
|
||
| dotenv_called: | ||
| cmds: | ||
| - echo "$FOO" > dotenv-called.txt | ||
| - echo "{{.FOO}}" > dotenv-called-2.txt |
There was a problem hiding this comment.
After this PR, this variable forwarding finally works. There's still room for improvement if the dotenv vars should be automatically propagated to any underlying task. But that could be handled separately.
|
This PR solves an issue I am running into (thank you @aminya)! For the maintainers: is there a plan or timeline for when this will be merged? Or is there another action required here before it can be considered ready? Thank you! |
|
can someone review and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #997
Task level dotenv didn't expand the variables referenced by
{{.var}}previously This fixes the issue. I added a test for it to prevent the bug from happening again.