Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrivPrecCompare: Add bot_in_blob_leq_bot so bot and Blob(bot) are considered equal #1645

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michael-schwarz
Copy link
Member

This was needed to not report spurious precision differences for the benchmarks in my thesis.
If we want this on the main branch, we can merge, otherwise we can close it.

@sim642
Copy link
Member

sim642 commented Dec 18, 2024

I haven't thought about it much or checked if this would completely break something, but I wonder if such thing could/should be non-optional. I think ValueDomain.join has cases for joining blobs with non-blobs by lifting the joining into the blob, etc. Perhaps something similar should be in leq unconditionally to maintain its algebraic consistency with join, etc.

I suspect domain quickchecking doesn't really work on ValueDomain, so such consistency might not be too easy to check that way.

@michael-schwarz
Copy link
Member Author

I am also not sure if one wants to have this in general, but I think having it in the compare scripts and having the option to dis/enable it, seems like it is generally a step in the right direction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants