Remove check for presence of secrets #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jace-ys
force-pushed
the
jace/no-secrets-exec
branch
3 times, most recently
from
d7a3d19 to
929e528
Compare
jace-ys
changed the title
theatre-envconsul assumes that your app needs secrets when you opt-in by annotating your service. when it doesn't find the vault: prefix, it errors as envconsul hangs when provided no secrets. we have now changed that assumption as gc-app now adds that annotation to every service, causing apps that don't use the vault: prefix (currently everything) to crash loop. with this change in our fork of envconsul, we no longer have to worry about envconsul hanging when no secrets are provided.
jace-ys
force-pushed
the
jace/no-secrets-exec
branch
from
43eb4e5 to
7f1ea8d
Compare
jace-ys
changed the title
jace-ys
force-pushed
the
jace/no-secrets-exec
branch
2 times, most recently
from
1573dca to
6cd38a4
Compare
jace-ys
force-pushed
the
jace/no-secrets-exec
branch
from
6cd38a4 to
ec1c655
Compare
dyson
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
theatre-envconsulassumes that your app needs secrets when you opt-in by annotating your service. when it doesn't find thevault:prefix, it errors as envconsul hangs when provided no secrets. we have now changed that assumption as gc-app now adds that annotation to every service, causing apps that don't use the vault: prefix (currently everything) to crash loop.with this change in our fork of envconsul, we no longer have to worry about envconsul hanging when no secrets are provided.