Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert a lot of command line arguments to snake case #498

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Convert a lot of command line arguments to snake case #498

merged 3 commits into from
Nov 6, 2023

Conversation

JanHoefelmeyer
Copy link
Contributor

Solves #494

@JanHoefelmeyer JanHoefelmeyer linked an issue Nov 6, 2023 that may be closed by this pull request
Unify variable names and config parameters #494
Closed
ThomasJunk
ThomasJunk previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works.

@ThomasJunk ThomasJunk self-requested a review November 6, 2023 10:19
ThomasJunk
ThomasJunk previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and should (still) work.

ThomasJunk
ThomasJunk approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-l-teichmann s-l-teichmann changed the title Convert a lot of variables to snake case Convert a lot of command line arguments to snake case Nov 6, 2023
s-l-teichmann
s-l-teichmann approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@s-l-teichmann s-l-teichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works (ran the integration test action)

@s-l-teichmann s-l-teichmann merged commit 086c4ab into main Nov 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasJunk ThomasJunk ThomasJunk approved these changes

@s-l-teichmann s-l-teichmann s-l-teichmann approved these changes

@bernhardreiter bernhardreiter Awaiting requested review from bernhardreiter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify variable names and config parameters
3 participants
@JanHoefelmeyer @s-l-teichmann @ThomasJunk