New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Android IAP in C# project to Godot 4.3 #1104

Merged

Calinou merged 3 commits into godotengine:master from JavierStark:update-android-iap-mono-4_3

Aug 23, 2024

Contributor

JavierStark commented Aug 22, 2024 •

edited

Loading

Attempt to update Android IAP in C# project to version 4.3 which was marked as needing an update in [#697]

Changes:

Dotnet target framework net472 -> net6.0
Correct use of Variants with AsType()
Signal connection using SignalName and callable creation with Callable.From()


          Update project to 4.3

9e6d65f

JavierStark changed the title ~~Update project to 4.3~~ Update Android IAP in C# project to Godot 4.3


          Simplify callable creation

0b47155

Calinou added update topic:dotnet labels

Calinou approved these changes

View reviewed changes

Member

Calinou left a comment •

edited

Loading

Thanks! Congratulations for your first merged pull request 🎉

Calinou mentioned this pull request

[TRACKER] Porting the demos to Godot 4 #697

Open

89 tasks

Calinou reviewed

View reviewed changes

mono/android_iap/Main.cs Outdated Show resolved Hide resolved

Calinou reviewed

View reviewed changes

mono/android_iap/Main.cs Outdated Show resolved Hide resolved

Calinou reviewed

View reviewed changes

mono/android_iap/Main.cs Outdated Show resolved Hide resolved

Calinou reviewed

View reviewed changes

mono/android_iap/Main.cs Outdated Show resolved Hide resolved

Calinou reviewed

View reviewed changes

mono/android_iap/Main.cs Outdated Show resolved Hide resolved

Calinou reviewed

View reviewed changes

mono/android_iap/Main.cs Outdated Show resolved Hide resolved

Calinou reviewed

View reviewed changes

mono/android_iap/Main.cs Outdated Show resolved Hide resolved

Calinou reviewed

View reviewed changes

mono/android_iap/Main.cs Outdated Show resolved Hide resolved

Calinou reviewed

View reviewed changes

mono/android_iap/Main.cs Outdated Show resolved Hide resolved

Calinou reviewed

View reviewed changes

mono/android_iap/Main.cs Outdated Show resolved Hide resolved

Calinou reviewed

View reviewed changes

mono/android_iap/Main.cs Outdated Show resolved Hide resolved


          Apply suggestions from code review

cac0c66

Calinou merged commit 13b2787 into godotengine:master

1 check passed

Contributor Author

JavierStark commented Aug 23, 2024

I found some problems when building for Android and after uploading into Google Play Store. I will fix it shortly

JavierStark mentioned this pull request

Fix updated Android IAP project in c# #1105

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:dotnet update