Fixed Script Errors for GUI Input Mapping Demo - 4.0-dev #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
reviewed
Apr 3, 2022
Comment on lines
-24
to
-25
| window/size/width=640 | ||
| window/size/height=480 |
There was a problem hiding this comment.
We should keep these lines, but they should be viewport_width instead of width and viewport_height instead of height.
There was a problem hiding this comment.
A question about this, should we always use 640x480 for viewport size? Because the defaults in 4.0 became bigger.
There was a problem hiding this comment.
The default in both 3 and 4 is 1024x600. Several of these demos have a smaller size because we just don't need a lot of space for such a simple demo. And no, we should definitely not always use 640x480. Just any demo that is already 640x480 in Godot 3 should still be that resolution in Godot 4.
Edited the project settings to match the new Godot 4 standard and fixed the script errors which were making it impossible to run this demo. Now everything works properly for the 4.0-dev version. Changed to Vulkan Mobile + Changed argument name Followed the suggestions of aaronfranke Changed viewport size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited the project settings to match the new Godot 4 standard and fixed
the script errors which were making it impossible to run this demo.
Now everything works properly for the 4.0-dev version.
Another check that can be added for #697.
I really hope that I'm doing a good job helping to make all these demo's run properly on Godot 4,
if I'm doing anything wrong, please say so I can improve myself.