feat: record metrics of conversion in task #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems some error happened in Concurrent, maybe the |
Desiki-high
force-pushed
the
feat/task-metric
branch
2 times, most recently
from
4715090 to
4fe8a7b
Compare
imeoer
reviewed
Sep 15, 2023
Desiki-high
force-pushed
the
feat/task-metric
branch
3 times, most recently
from
f2515af to
4434483
Compare
Signed-off-by: Yadong Ding <[email protected]>
Desiki-high
force-pushed
the
feat/task-metric
branch
from
4434483 to
d3616d1
Compare
We have collected the metrics of conversion progress. Let's show them in task. Add the `SourceSize` and `TargetSize` in task and record them when task finished. Signed-off-by: Yadong Ding <[email protected]>
imeoer
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have collected the metrics of conversion progress. Let's show them in the task. Add the
SourceImageSizeandTargetImageSizein the task and record them when the task is finished.resolve #191.