Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reading auth from docker config #194

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

Desiki-high
Copy link
Collaborator

User can don't put the auth in config file, just use docker/nerdctl login.
Acceld will try to read registry auth from the docker config if cant't find auth in config file.

resolve #29 .

@Desiki-high Desiki-high requested a review from imeoer September 19, 2023 03:22
@Desiki-high Desiki-high added the feat New feature or request label Sep 19, 2023
misc/config/config.estargz.yaml Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
@Desiki-high Desiki-high force-pushed the auth-docker-config branch 2 times, most recently from 6d26b94 to b3cb850 Compare September 25, 2023 08:53
@Desiki-high Desiki-high requested a review from imeoer September 25, 2023 08:56
User can don't put the auth in config file, just use docker/nerdctl login.
Acceld will try to read registry auth from the docker config if cant't find auth in config file.

Signed-off-by: Yadong Ding <[email protected]>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit 3c73e7b into goharbor:main Sep 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can deamonless accelctl parse parameter directly?
2 participants