-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create refactor_log-driver_docker-check_podman-support.md #208
base: main
Are you sure you want to change the base?
Conversation
According to: goharbor/harbor#15986 (comment) I'm submitting this document to give the start for a possible harbor podman support. Signed-off-by: Leo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, we should not make Harbor dependent on Docker.
@qnetter ping for awareness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@leonidas-o can you provide a bit more information here about the implementation please as @wy65701436 would love to review! Thanks! Also are you able to work on this one if accepted @leonidas-o ? :) |
@OrliX, I think the initial implementation is already there in the referenced PR |
@Vad1mo wrong Orlix :) @OrlinVasilev here :D anyway ... in the morning PR triaging @wy65701436 wanted to have some more meat here so the proposal is complete in the terms of implementation! @wy65701436 can you comment what exactly you were referring ? Thank you! :) |
@OrlinVasilev unfortunately I can't provide more info on the implementation itself, see the point
So it's a decision you guys have to take. For each point, both ways work (1. syslog configurable or new default value, 2. checks removed or extended), the question is, which way you want to go, which way makes to most sense for the product? |
@leonidas-o thank you so much! |
besides the installation, have you tried to use podman(like we are doing on docker) to interact with Harbor, pull/push oci invidual artifact and index? |
To have the podman into the support list is a good idea, I would like to see this proposal can cover all parts of podman support, rather than just refactor the log driver part. Do we need to enable podman pipelines for any pull requests? |
Don't know if the question according to the interaction podman to harbor is for me, but yes, I'm using podman all the time with harbor. In fact the most of my VM's are running with podman. I've also got a gitlab-runner on podman, which is pulling from harbor, tagging and pushing to harbor. "Which podman version do we recommend starting support from?" |
@wy65701436 I think it would make sense to push this forward, more and more people are nowadays using podman. |
According to: goharbor/harbor#15986 (comment) I'm submitting this document to give the start for a possible harbor podman support.
Signed-off-by: Leo [email protected]