-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Visibility Levels and enforcement Levels for Projects #242
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Vadim Bauer <[email protected]>
Signed-off-by: Vadim Bauer <[email protected]>
+1 |
Perhaps you want to have a way to explicitly tag users as "internal". So internal projects are not accidentally exposed to customers, who have an account to download software delivered to them. Otherwise, I find the proposal quite useful for larger organisations. |
thank you for your input. This is not in scope for this proposal. In this context, internal does not refer to users but to networks, this would be a separate use case IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
users can view and pull artifacts from this project. | ||
But they are not allowed to pull any artifact from this project unless they are explicitly added as members to the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a copy-pasta issue: In 44 you say "users can view and pull". Next line "But they are not allowed to pull".
we want the internal projects | ||
to be visible and accessible inside the organization, but private to the outside. | ||
The same would apply to pulling artifacts, | ||
internally without a pull secret and externally just like a private project with a pull secret. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what means internally / externally in this context?
|
||
To handle this the internal use case, we would need | ||
to have a functionality | ||
that can distinguish between access from internal or external networks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding the complexity of networking here makes the proposal bigger than it needs to be.
For me it's about authorizing all authenticated identities to a project by default.
IMHO adding networking brings much complexity and risk with it.
that are explicitly added as members to the project to get access, | ||
based on their access level. | ||
- **Internal View Only** | ||
All authenticated (hence authenticated) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"hence authenticated", you mean authorized?
add related issue Signed-off-by: Vadim Bauer <[email protected]>
|
||
## Abstract | ||
|
||
This proposal extends Harbor with additional project visibility and permission levels, and upgrades the current public/private project visibility and access levels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, the document lacks of technical parts to let other maintainers know how to handle the newly introduced level?
The scheme changes? And the data migration?
The RBAC mode for the internal project?
API change?
Any downstream impact?
And also, could you add persona? user story?
This proposal extends Harbor with additional project visibility and permission levels and upgrades the current public/private project visibility and access, making Harbor Suitable for more use cases.