-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Command is Incorrect #270
Comments
FIX: use ldflags to add version on build. |
would it make sense to add a Makefile that takes care of those things? |
@bupd I added a PR that includes a Makefile for those kind of things. Please feel free to have a look |
We already have dagger and It's better than Makefiles. So we don't need makefiles. I am currently experimenting with the build and publish workflow we have in dagger. |
@qcserestipy You can try updating the build function present in https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=harbor-cli#n26 using the similar build function we use to build for aur would be great. Hope it helps. |
@bupd thank you for the hint, i will try that! |
Builds should produce the version command with the correct version.
and provide necessary details.
Current version Command
Expected
The text was updated successfully, but these errors were encountered: