Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Command is Incorrect #270

Open
bupd opened this issue Nov 27, 2024 · 6 comments · May be fixed by #273
Open

Version Command is Incorrect #270

bupd opened this issue Nov 27, 2024 · 6 comments · May be fixed by #273

Comments

@bupd
Copy link
Member

bupd commented Nov 27, 2024

Builds should produce the version command with the correct version.
and provide necessary details.

Current version Command

❯ harbor version
Version:      0.1.0
Go version:
Git commit:
Built:
OS/Arch:      linux/amd64

Expected

❯ harbor version
Version:      v0.0.1
Go version:   go1.23.3
Git commit:   f9a099cd2c763ff8d0c282cd223f626b88caa456
Built:        2024-11-27T20:36:32Z
OS/Arch:      linux/amd64
@bupd
Copy link
Member Author

bupd commented Nov 27, 2024

FIX: use ldflags to add version on build.

@qcserestipy
Copy link
Contributor

would it make sense to add a Makefile that takes care of those things?

@qcserestipy
Copy link
Contributor

@bupd I added a PR that includes a Makefile for those kind of things. Please feel free to have a look

@bupd
Copy link
Member Author

bupd commented Nov 28, 2024

We already have dagger and It's better than Makefiles. So we don't need makefiles.

I am currently experimenting with the build and publish workflow we have in dagger.

@bupd
Copy link
Member Author

bupd commented Nov 28, 2024

@qcserestipy You can try updating the build function present in dagger/main.go. to fix this.

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=harbor-cli#n26 using the similar build function we use to build for aur would be great. Hope it helps.

@qcserestipy
Copy link
Contributor

@bupd thank you for the hint, i will try that!

@qcserestipy qcserestipy linked a pull request Nov 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants