270 add ldflags to dagger #273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bupd
requested changes
Nov 28, 2024
bupd
requested changes
Dec 17, 2024
Signed-off-by: Patrick Eschenbach <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
…back version; Fixed dev version to static version Signed-off-by: Patrick Eschenbach <[email protected]>
…back version; Fixed dev version to static version; Removed bin files Signed-off-by: Patrick Eschenbach <[email protected]>
Signed-off-by: bupd <[email protected]> Signed-off-by: Patrick Eschenbach <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
qcserestipy
force-pushed
the
270_add_ldflags_to_dagger
branch
from
9b38543 to
82c0b8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #270
I added the ldflags to the buildDev and build function to account for the version flags.
Git needs to be installed on the fly in the dagger service to retrieve these values.