created build-dev dagger function for enhance developer workflow #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ALTHAF <[email protected]>
bupd
requested changes
Aug 16, 2024
main.go
Outdated
Comment on lines
86
to
98
| // Return a container that build the Harbor binary for development purposes. | ||
| func (m *HarborCli) BuildDev(ctx context.Context, directoryArg *dagger.Directory) *dagger.Container { | ||
| fmt.Println("🛠️ Building Harbor binary with Dagger...") | ||
|
|
||
| // Define the path for the binary output | ||
| binaryOutputPath := "/src/bin/harbor" | ||
| return dag.Container(). | ||
| From("golang:latest"). | ||
| WithMountedDirectory("/src", directoryArg). | ||
| WithWorkdir("/src/cmd/harbor"). | ||
| WithExec([]string{"go", "build", "-o", binaryOutputPath, "main.go"}). | ||
| WithWorkdir("/src") | ||
| } |
There was a problem hiding this comment.
- Update build-dev to produce binary out of the box without any args or flags such as directory.
dagger call build-devshould work.
|
@Althaf66 Additionally, build-dev should actually be able to build harbor based on their system. So devs on windows and Linux can use it. |
Signed-off-by: ALTHAF <[email protected]>
bupd
requested changes
Aug 18, 2024
Signed-off-by: ALTHAF <[email protected]>
Signed-off-by: ALTHAF <[email protected]>
|
closing if favor #219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #163
Added build-dev dagger function to build the Harbor binary for development purposes.
Updated existing Dagger functions with descriptions.