Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add '--force' flag to delete non-empty projects #252

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Add '--force' flag to delete non-empty projects #252

merged 2 commits into from
Nov 26, 2024

Conversation

adwait-godbole
Copy link
Contributor

@adwait-godbole adwait-godbole commented Nov 14, 2024 •
edited
Loading

Fixes #243

Screencast.from.2024-11-14.17-03-59.webm

Hi @Vad1mo @bupd, I tried fixing the problem and it is working fine on my machine as you can see in the above video. Let me know if any improvements should be done to do this approach as it is my very first time contributing to Harbor. Thanks for this amazing project!

@adwait-godbole
Copy link
Contributor Author

adwait-godbole commented Nov 14, 2024 •
edited
Loading

@Vad1mo thanks for enabling the CI on my PR. I have got the same failure when I was trying to publish a draft release on my fork over here following the documentation giving in RELEASE.md. I am not sure what is causing "Run Tests" to fail. Could you please help me by pointing out what am I doing wrong? Thanks.

@Vad1mo
Copy link
Member

Vad1mo commented Nov 14, 2024

@adwait-godbole can you rebase your changes on latest main? I think then the tests should work

@adwait-godbole
Copy link
Contributor Author

@adwait-godbole can you rebase your changes on latest main? I think then the tests should work

@Vad1mo I have done the rebase but I guess your approval is again required for triggering the workflow. Also when I drafted a test release on my fork, the triggered workflow still failed during the "Run Tests" job --> https://github.com/adwait-godbole/harbor-cli/actions/runs/11851195614.

@adwait-godbole
Copy link
Contributor Author

@bupd can you please review this one as well. I think the issue you have pointed out at #249 might be the reason that the tests are failing. Am I correct? Or is it something else?

@bupd bupd self-requested a review November 21, 2024 08:41
bupd
bupd approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vad1mo Vad1mo merged commit 5bbf322 into goharbor:main Nov 26, 2024
5 checks passed
qcserestipy pushed a commit to qcserestipy/harbor-cli that referenced this pull request Dec 22, 2024
@adwait-godbole @Vad1mo @qcserestipy
add '--force' flag to delete non-empty projects (goharbor#252)
3b79257 
Signed-off-by: adwait-godbole <[email protected]>
Signed-off-by: Vadim Bauer <[email protected]>
Co-authored-by: Vadim Bauer <[email protected]>
Signed-off-by: Patrick Eschenbach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bupd bupd bupd approved these changes

@Vad1mo Vad1mo Vad1mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Force deletes non empty projects
3 participants
@adwait-godbole @Vad1mo @bupd