Better errormessage

cmd/harbor/root/registry/create.go

@@ -2,6 +2,7 @@ package registry
 
 import (
 	"github.com/goharbor/harbor-cli/pkg/api"
+	"github.com/goharbor/harbor-cli/pkg/errors"
 	"github.com/goharbor/harbor-cli/pkg/views/registry/create"
 	log "github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
@@ -37,7 +38,7 @@ func CreateRegistryCommand() *cobra.Command {
 			}
 
 			if err != nil {
-				log.Errorf("failed to create registry: %v", err)
+				log.Errorf("failed to create registry: %v", errors.ErrorCreateRegistry(err))
 			}
 		},
 	}

cmd/harbor/root/registry/delete.go

@@ -2,6 +2,7 @@ package registry
 
 import (
 	"github.com/goharbor/harbor-cli/pkg/api"
+	"github.com/goharbor/harbor-cli/pkg/errors"
 	"github.com/goharbor/harbor-cli/pkg/prompt"
 	log "github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
@@ -25,7 +26,7 @@ func DeleteRegistryCommand() *cobra.Command {
 				err = api.DeleteRegistry(registryId)
 			}
 			if err != nil {
-				log.Errorf("failed to delete registry: %v", err)
+				log.Errorf("failed to delete registry: %v", errors.ErrorDeleteRegistry(err))
 			}
 		},
 	}

cmd/harbor/root/registry/list.go

@@ -2,6 +2,7 @@ package registry
 
 import (
 	"github.com/goharbor/harbor-cli/pkg/api"
+	"github.com/goharbor/harbor-cli/pkg/errors"
 	"github.com/goharbor/harbor-cli/pkg/utils"
 	"github.com/goharbor/harbor-cli/pkg/views/registry/list"
 	log "github.com/sirupsen/logrus"
@@ -20,7 +21,7 @@ func ListRegistryCommand() *cobra.Command {
 			registry, err := api.ListRegistries(opts)
 
 			if err != nil {
-				log.Fatalf("failed to get projects list: %v", err)
+				log.Fatalf("failed to get projects list: %v", errors.ErrorListRegistry(err))
 			}
 			FormatFlag := viper.GetString("output-format")
 			if FormatFlag != "" {

cmd/harbor/root/registry/update.go

@@ -2,6 +2,7 @@ package registry
 
 import (
 	"github.com/goharbor/harbor-cli/pkg/api"
+	"github.com/goharbor/harbor-cli/pkg/errors"
 	"github.com/goharbor/harbor-cli/pkg/prompt"
 	"github.com/goharbor/harbor-cli/pkg/views/registry/create"
 	log "github.com/sirupsen/logrus"
@@ -51,7 +52,7 @@ func UpdateRegistryCommand() *cobra.Command {
 			}
 
 			if err != nil {
-				log.Errorf("failed to update registry: %v", err)
+				log.Errorf("failed to update registry: %v", errors.ErrorUpdateRegistry(err))
 			}
 		},
 	}

cmd/harbor/root/registry/view.go

@@ -3,6 +3,7 @@ package registry
 import (
 	"github.com/goharbor/go-client/pkg/sdk/v2.0/client/registry"
 	"github.com/goharbor/harbor-cli/pkg/api"
+	"github.com/goharbor/harbor-cli/pkg/errors"
 	"github.com/goharbor/harbor-cli/pkg/prompt"
 	"github.com/goharbor/harbor-cli/pkg/utils"
 	"github.com/goharbor/harbor-cli/pkg/views/registry/view"
@@ -35,7 +36,7 @@ func ViewRegistryCommand() *cobra.Command {
 			registry, err = api.ViewRegistry(registryId)
 
 			if err != nil {
-				log.Errorf("failed to get registry info: %v", err)
+				log.Errorf("failed to get registry info: %v", errors.ErrorViewRegistry(err))
 				return
 			}
 

pkg/errors/registry_error.go

@@ -0,0 +1,50 @@
+package errors
+
+import (
+	"github.com/goharbor/harbor-cli/pkg/utils"
+)
+
+func getErrorMessage(statusCode int64, action string) string {
+	switch statusCode {
+	case 400:
+		if action == "create" {
+			return "Give adequate information to create a registry."
+		}
+	case 401:
+		return "Registry Unauthorized"
+	case 403:
+		return "Registry Forbidden"
+	case 404:
+		return "Registry is not found"
+	case 409:
+		if action == "create" {
+			return "Registries with the same name exist"
+		}
+		return "Conflict"
+	case 412:
+		return "Registry is not found"
+	case 500:
+		return "Internal Server Error"
+	}
+	return "cannot identify the status code"
+}
+
+func ErrorCreateRegistry(err error) string {
+	return getErrorMessage(utils.ErrorStatusCode(err), "create")
+}
+
+func ErrorDeleteRegistry(err error) string {
+	return getErrorMessage(utils.ErrorStatusCode(err), "delete")
+}
+
+func ErrorViewRegistry(err error) string {
+	return getErrorMessage(utils.ErrorStatusCode(err), "view")
+}
+
+func ErrorListRegistry(err error) string {
+	return getErrorMessage(utils.ErrorStatusCode(err), "list")
+}
+
+func ErrorUpdateRegistry(err error) string {
+	return getErrorMessage(utils.ErrorStatusCode(err), "update")
+}

pkg/utils/error.go

@@ -1 +1,23 @@
 package utils
+
+import (
+	"regexp"
+	"strconv"
+
+	log "github.com/sirupsen/logrus"
+)
+
+func ErrorStatusCode(err error) int64 {
+	re := regexp.MustCompile(`\[(\d{3})\]`)
+	matches := re.FindStringSubmatch(err.Error())
+
+	var statusCode int64
+	if len(matches) > 1 {
+		stringCode := matches[1]
+		statusCode, err = strconv.ParseInt(stringCode, 10, 64)
+		if err != nil {
+			log.Fatal(err)
+		}
+	}
+	return statusCode
+}