Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Page size #290

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Roaster05
Copy link
Contributor

Description

This PR enhances the handling of the page-size parameter by introducing a hierarchical priority mechanism and integrating it into the command execution flow.

Hierarchy for page-size Resolution

  1. Flag: The value provided via the command flag takes the highest priority.
  2. ResolvePageSize Utility: If no flag is provided, the utility determines the page-size in the following order:
    • Value from the configuration file.
    • Value from the HARBOR_CLI_DEFAULT_PAGE_SIZE environment variable.
    • Hardcoded default value (x).

Key Changes

  1. Command Execution:
    • Updated list commands to prioritize page-size values using the hierarchy mentioned above.
  2. Config Updates:
    • Introduced a new parameter for page-size in the configuration.
    • Added initialization for this parameter in the relevant configuration files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant