Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding docker image support with docker publish Github_action #58

Closed
wants to merge 9 commits into from

Conversation

bishal7679
Copy link
Contributor

@bishal7679 bishal7679 commented May 19, 2024

Fixes ⇾ part of #7

Previous State

  • Docker building image was missing and also auto publish Docker image through GitHub_action

Current Behavior

  • Added Dockerfile to build the harbor-cli image
  • Integrated GitHub Action to auto publish the current version of harbor image to Docker hub

Needs to be set

  • Set the secrets in the repository scope using below naming convention
    • DOCKER_USERNAME
    • DOCKER_PASSWORD
  • Create a separate repository in Docker Hub repository named harbor-cli and Docker hub account name goharbor (can be changed if already existing any account)
    • like this → goharbor/harbor-cli

To trigger the github action, just need to push any changes in main branch or any pull request

//cc @Vad1mo @amands98

Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you build the image an push it to the registry registry.goharbor.io

Image name using thirs domain and library repository name registry.goharbor.io/library/harbor-cli:1.2.3

The creads are in those variables.

  • REGISTRY_GOHARBOR_ROBOT_USER_NAME
  • REGISTRY_GOHARBOR_ROBOT_USER_SECRET

@Althaf66 Althaf66 added invalid This doesn't seem right and removed invalid This doesn't seem right labels Sep 18, 2024
Copy link
Member

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bishal7679 fix DCO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants