add ttlSecondsAfterFinished for migration-job #1600
Conversation
Signed-off-by: kychen <[email protected]>
|
@zyyw Can you help me review this PR? |
There was a problem hiding this comment.
According to this doc, there are two options that may achieve the purpose of deleting the job after the hook is successfully executed:
- add a custom helm.sh/hook-delete-policy annotation
- set the time to live (TTL) field of a Job resource
Should we use the first option to only delete the job when the hook is completed successfully? Therefore, users can still investigate the job log if anything goes wrong.
@zyyw Yes, it can also be handled by annotation. The current default behavior is before-hook-creation. In the case of uninstallation, several strategies supported by helm do not seem to work well. The problem I want to solve is that there should be no resources left after uninstalling. |
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
|
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main. |
Signed-off-by: kychen [email protected]
#1599