Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix messy table in README #1650

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix messy table in README #1650

merged 1 commit into from
Dec 6, 2023

Conversation

An-DJ
Copy link
Contributor

@An-DJ An-DJ commented Dec 1, 2023

No description provided.

@zyyw
Copy link
Collaborator

zyyw commented Dec 5, 2023

Hi @An-DJ , thanks for contributing to Harbor-helm! Could you please rebase the main branch and resolve the conflict as well? Thanks

@An-DJ
Fix messy table in README
2850c78 
Signed-off-by: Junduo Dong <[email protected]>
@An-DJ
Copy link
Contributor Author

An-DJ commented Dec 6, 2023

Hi @An-DJ , thanks for contributing to Harbor-helm! Could you please rebase the main branch and resolve the conflict as well? Thanks

@zyyw Done. : )

MinerYang
MinerYang approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit a971e5d into goharbor:main Dec 6, 2023
6 checks passed
@An-DJ An-DJ deleted the patch-1 branch December 6, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinerYang MinerYang MinerYang approved these changes

@zyyw zyyw zyyw approved these changes

Assignees
No one assigned
Labels
target/1.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@An-DJ @zyyw @MinerYang