Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define different deploy strategy for jobservice #1659

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

define different deploy strategy for jobservice #1659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
068971e
define different deploy strategy for jobservice
Dec 8, 2023
2cb5771
Merge branch 'goharbor:main' into main
gminiba Mar 21, 2024
0023d08
Update values.yaml
gminiba Aug 13, 2024
ded97c9
Update README.md
gminiba Aug 13, 2024
74875b2
Update README.md
gminiba Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ The following table lists the configurable parameters of the Harbor chart and th
| `jobservice.image.tag` | Tag for jobservice image | `dev` |
| `jobservice.replicas` | The replica count | `1` |
| `jobservice.revisionHistoryLimit` | The revision history limit | `10` |
| `jobservice.updateStrategy.type` | The update strategy for jobservice deployment (if needs to be different from others): `RollingUpdate` or `Recreate`. Set it as `Recreate` when `RWM` for volumes isn't supported | same as general `updateStrategy.type`|
| `jobservice.maxJobWorkers` | The max job workers | `10` |
| `jobservice.jobLoggers` | The loggers for jobs: `file`, `database` or `stdout` | `[file]` |
| `jobservice.loggerSweeperDuration` | The jobLogger sweeper duration in days (ignored if `jobLoggers` is set to `stdout`) | `14` |
Expand Down
5 changes: 3 additions & 2 deletions templates/jobservice/jobservice-dpl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ spec:
replicas: {{ .Values.jobservice.replicas }}
revisionHistoryLimit: {{ .Values.jobservice.revisionHistoryLimit }}
strategy:
type: {{ .Values.updateStrategy.type }}
{{- if eq .Values.updateStrategy.type "Recreate" }}
{{- $strategyType := (.Values.jobservice.strategyType | default .Values.updateStrategy.type) }}
type: {{ $strategyType }}
{{- if eq $strategyType "Recreate" }}
rollingUpdate: null
{{- end }}
selector:
Expand Down
3 changes: 3 additions & 0 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,9 @@ jobservice:
# mount the service account token
automountServiceAccountToken: false
replicas: 1
# uncomment following lines to specify different updateStrategy for jobService
# updateStrategy:
# type: ReCreate
revisionHistoryLimit: 10
# resources:
# requests:
Expand Down