Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HPA #1765

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add support for HPA #1765

wants to merge 9 commits into from

Conversation

xoanmi
Copy link
Contributor

@xoanmi xoanmi commented May 31, 2024

We are adding support for autoscale deployments with [Horizontal Pod Autoscaling (HPA)] on all Harbor services.

This change is backwards compatible since it adds new functionality. With the default values, the new settings have no effect.

Close #1068

xoanmi and others added 4 commits May 31, 2024 10:13
Signed-off-by: Joan Miquel Luque Oliver <[email protected]>
Signed-off-by: Shengwen Yu <[email protected]>
Signed-off-by: Joan Miquel Luque Oliver <[email protected]>
Signed-off-by: Shengwen Yu <[email protected]>
Signed-off-by: Joan Miquel Luque Oliver <[email protected]>
Signed-off-by: Joan Miquel Luque Oliver <[email protected]>
Signed-off-by: Joan Miquel Luque Oliver <[email protected]>
@zyyw
Copy link
Collaborator

zyyw commented Jun 13, 2024

this is currently not on the roadmap on harbor-helm.

@zyyw zyyw closed this Jun 13, 2024
@cvegagimenez
Copy link
Contributor

Hi @zyyw ,

does that mean that you are not approving anything that is not in the roadmap even if it adds new functionalities and does not affect the current setup?

As you can see here there are an issue that request this kind of feature.

Anyway, in the CONTRIBUTING page it says nothing about the roadmap to contribute. Can you share with us what is the process to include new features in this project?

@xoanmi
Copy link
Contributor Author

xoanmi commented Jun 17, 2024

I'm providing a feature that many in the community have requested. The Horizontal Pod Autoscaler (HPA) is a well-established Kubernetes feature. Even if it's not on the roadmap, why not include it? I've ensured it is fully backwards compatible and doesn't affect anything else.

This is disappointing 😢

@wy65701436
Copy link
Contributor

Thanks @xoanmi for your idea and contribution.

We don't want to provide an all-in-one solution to the customer, as it is not considered a good engineering practice. Instead, we aim to deliver a stable, useful, and minimal version of harbor-helm. The primary goal of harbor-helm is to offer our users a straightforward way to deploy Harbor into their Kubernetes clusters, with the main task being to align with the latest Harbor version.

Adding more functionalities is not our top priority. From a maintenance perspective, keeping things simple and small is often more beneficial.

@cvegagimenez, regarding support for HPA, we believe this should be an additional feature of harbor-helm. And user can actually complete it at their end manually. Currently, harbor-helm is already quite complex to maintain, and we understand that the community wants to see comprehensive features. Let's keep this discussion open to gather more insights from the community.

@wy65701436 wy65701436 reopened this Jun 18, 2024
@xoanmi
Copy link
Contributor Author

xoanmi commented Jun 18, 2024

Thanks for the insights @wy65701436.

We can proceed as you suggest, but we need a method to disable the replicas for each service we manage with the HPA. Since we are using a GitOps approach, it's crucial to avoid reconciliation issues, where the HPA modifies the replicas and then ArgoCD changes them back in an infinite loop.

@dannyeuu
Copy link

This is a great feature!

Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Sep 18, 2024
@xoanmi
Copy link
Contributor Author

xoanmi commented Sep 18, 2024

Is anyone able to review/approve this PR? 🥺

@github-actions github-actions bot removed the Stale label Sep 19, 2024
@sumeet-zuora
Copy link

Looks a great addition to harbor helm

@sumeet-zuora
Copy link

@xoanmi seems ur master is many commits behind the master of harbor-helm

@xoanmi
Copy link
Contributor Author

xoanmi commented Dec 17, 2024

Fixed tests by @cvegagimenez 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add feature HPA on core, trivy and registry
6 participants