Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: core service ready/liveness probes to be configurable #1855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dylanhitt
Copy link

Recently ran into an issue on our cluster that has a lot of churn (we use karpenter and leverage spot instances pretty heavily). For some reason there are points when a new node in the cluster comes up and the AWS VPC CNI resyncs we see a bit of latency. I couldn't quite figure out why. The 1 second timeout on the readiness probe procs fails quite a bit causing noise in our events monitoring as well as sometimes restarting the container when it seems otherwise healthy.

The only way I found to solve the issue is to increase the timeoutSeconds.

Let me know what you all think.

Cheers

@MinerYang
Copy link
Collaborator

Hi @dylanhitt ,

Thanks for your contribution!
We understood you may have some latency from your Kubernetes infra level. However it is not a common level, could you try to maintain this config first at your side, and we will see if more users from community will needs this.

Best,
Miner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants