rollingUpdate only allowed if type=RollingUpdate #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gkramer , This rollingUpdate line is for Rolling update config params is update strategy is not Recreate. And normally this strategy is either Recreate or Rolling Update. So I don't see any problem of this, and if we delete this line as you presents in the PR, the config for rolling update would lost as well. |
|
Hi @gkramer , Could you please add the sign-off? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://v1-28.docs.kubernetes.io/docs/reference/kubernetes-api/workload-resources/deployment-v1/#DeploymentSpec