Provide more TLS names which will be valid for the TLS cert #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonTheNiceGuy
force-pushed
the
patch-1
branch
from
bf6b1fe to
f45b255
Compare
The names are:
`localhost`
`{{ .Release.Name }}`
`{{ .Release.Name }}.{{ .Release.Namespace }}`
`{{ .Release.Name }}.{{ .Release.Namespace }}.svc`
`{{ .Release.Name }}.{{ .Release.Namespace }}.svc.cluster.local`
Signed-off-by: Jon Spriggs <[email protected]>
JonTheNiceGuy
force-pushed
the
patch-1
branch
from
f45b255 to
b0e220f
Compare
|
This doesn't solve for the usecase I was hoping for. Apologies for the noise with the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names are:
127.0.0.1(existing)localhost(existing){{ .Release.Name }}(existing){{ .Release.Name }}.{{ .Release.Namespace }}(new){{ .Release.Name }}.{{ .Release.Namespace }}.svc(new){{ .Release.Name }}.{{ .Release.Namespace }}.svc.cluster.local(new)