-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: postgresql not deleted with harborcluster (master) #1014
Open
samuelchen
wants to merge
2
commits into
goharbor:main
Choose a base branch
from
samuelchen:fix-postgresql-owner-ref
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ownerReference to expectCR in PostgreSQLController.Update before comparing. Origin expectCR have no OwnerReference . Signed-off-by: 陈伟 <[email protected]>
samuelchen
force-pushed
the
fix-postgresql-owner-ref
branch
from
February 6, 2023 09:24
98b811c
to
0f10cfa
Compare
ShouEnHsiao
added a commit
to ShouEnHsiao/harbor-operator
that referenced
this pull request
Aug 8, 2023
This CL is from goharbor#1014 which adds ownerReference to expectCR in PostgreSQLController.Update before comparing. Origin expectCR have no OwnerReference. Signed-off-by: Shou-En Hsiao <[email protected]>
ShouEnHsiao
added a commit
to ShouEnHsiao/harbor-operator
that referenced
this pull request
Aug 8, 2023
This CL is from goharbor#1014 which adds ownerReference to expectCR in PostgreSQLController.Update before comparing. Origin expectCR have no OwnerReference. Signed-off-by: Shou-En Hsiao <[email protected]>
ShouEnHsiao
added a commit
to ShouEnHsiao/harbor-operator
that referenced
this pull request
Aug 8, 2023
This CL is from goharbor#1014 which adds ownerReference to expectCR in PostgreSQLController.Update before comparing. Origin expectCR have no OwnerReference. Signed-off-by: ShouEnHsiao <[email protected]>
thcdrt
pushed a commit
that referenced
this pull request
Aug 21, 2023
This CL is from #1014 which adds ownerReference to expectCR in PostgreSQLController.Update before comparing. Origin expectCR have no OwnerReference. Signed-off-by: ShouEnHsiao <[email protected]>
cndoit18
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference .