Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: postgresql not deleted with harborcluster (master) #1014

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

samuelchen
Copy link

@samuelchen samuelchen commented Feb 6, 2023

add ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference .

add ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference .

Signed-off-by: 陈伟 <[email protected]>
@samuelchen samuelchen force-pushed the fix-postgresql-owner-ref branch from 98b811c to 0f10cfa Compare February 6, 2023 09:24
ShouEnHsiao added a commit to ShouEnHsiao/harbor-operator that referenced this pull request Aug 8, 2023
This CL is from goharbor#1014
which adds ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference.

Signed-off-by: Shou-En Hsiao <[email protected]>
ShouEnHsiao added a commit to ShouEnHsiao/harbor-operator that referenced this pull request Aug 8, 2023
This CL is from goharbor#1014
which adds ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference.

Signed-off-by: Shou-En Hsiao <[email protected]>
ShouEnHsiao added a commit to ShouEnHsiao/harbor-operator that referenced this pull request Aug 8, 2023
This CL is from goharbor#1014
which adds ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference.

Signed-off-by: ShouEnHsiao <[email protected]>
thcdrt pushed a commit that referenced this pull request Aug 21, 2023
This CL is from #1014
which adds ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference.

Signed-off-by: ShouEnHsiao <[email protected]>
@steven-zou steven-zou requested a review from cndoit18 September 6, 2024 10:01
Copy link
Collaborator

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants