implement harbor project day2 configuration

[ChristianLoewel]

I decided to implement this as I need the harbor project day2 configuration for myself.

This adds the ability to create, update and delete Harbor projects via Kubernetes resources, including their metadata, group/user memberships and storage quotas.

I tried to provide unit tests, however I don't have much experience with go tests yet and due to the lack of already existing day2 tests to base mine off of I decided against it.

For the implementation I strongly oriented myself on the existing pull request for robotaccount day2, extending the REST client wrapper and using the HarborServerConfiguration CustomResource.

Currently, the operator plainly deletes a harbor project if a corresponding HarborProject CustomResource was deleted. It may be necessary to implement a way to optionally skip deleting the project when deleting the CustomResource. This would allow disabling the operator management of a project without deleting it and would limit the damage of accidental deletions.

I look forward to your feedback.

Signed-off-by: Christian Löwel [email protected]

[MarcelMue]

I will review the PR soon - please sign the DCO, so CI can be run.

[thcdrt]

Thank you for your contribution, I have some suggestions and questions

[thcdrt]

@ChristianLoewel can you resolve conflicts please ?

[ChristianLoewel]

Done! Will create a new pull request in a few weeks with tag retention policy, tag immutability, labels.

[thcdrt]

@MarcelMue Helm charts tests are broken, is it linked to the move of the CRD out of the chart ?

[MarcelMue]

@MarcelMue Helm charts tests are broken, is it linked to the move of the CRD out of the chart ?

Something went wrong when rebasing here. This PR currently adds back the entire CRD into the helm chart. See how it adds 40k lines right now - I believe that is why the test is failing.

[ChristianLoewel]

My bad, wasn't aware of the crd change. I removed it now.

[MarcelMue]

I am generally very happy with the contribution. I think we should add some testing for the newly added functionalities here (so we test new features in CI). I am happy if this is done in a follow up / collaboration.

Sorry that it took so long to get this PR reviewed / unblocked 🙇‍♂️

[MarcelMue]

@ChristianLoewel can you provide some manifests (e.g. sample yaml config of CRDs) which you used for testing the added features in #1044 ? It will be helpful later on to more easily add tests.

[ChristianLoewel]

Hi, sorry for the delay. I have created some test resources, let me know if you miss any cases.

https://gist.github.com/ChristianLoewel/24fc73b8ac740be5d89283a64df15c53

Tests would be great, I like the idea of the collaboration. Will definitely need your help with that.

[MarcelMue]

Thanks for the contribution @ChristianLoewel ! If you want to collaborate more, please feel free to join the #harbor-dev channel in the cncf slack: https://cloud-native.slack.com/messages/harbor-operator-dev/

[chlins]

Hi, sorry for the delay. I have created some test resources, let me know if you miss any cases.

https://gist.github.com/ChristianLoewel/24fc73b8ac740be5d89283a64df15c53

Tests would be great, I like the idea of the collaboration. Will definitely need your help with that.

@ChristianLoewel Hi, could you please paste the example resources to the documents?

[ChristianLoewel]

Hi @chlins, I have created a pull request #1066 to add the examples to the doc.

Additionally, a second PR #1067 fixes a reconciliation issue with HarborProjects I have noticed while using the feature.