Adding support for proxy when preparing registry layers #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: david-newhook <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 50.35% 46.09% -4.27%
==========================================
Files 13 14 +1
Lines 556 564 +8
==========================================
- Hits 280 260 -20
- Misses 259 286 +27
- Partials 17 18 +1
Continue to review full report at Codecov.
|
danielpacak
suggested changes
Oct 7, 2021
There was a problem hiding this comment.
Thanks for this PR @dnewhook The change looks good to me. I just left a minor comment to format the code.
| @@ -47,6 +47,7 @@ func (cf *clientFactory) Get() Client { | |||
| RootCAs: cf.tlsConfig.RootCAs, | |||
| InsecureSkipVerify: cf.tlsConfig.InsecureSkipVerify, | |||
| }, | |||
| Proxy: http.ProxyFromEnvironment, | |||
There was a problem hiding this comment.
Use tabs instead of spaces:
gofmt -w pkg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container will respect environment variables when connecting to a registry to prepare layers:
HTTP_PROXY
HTTPS_PROXY
NO_PROXY
This is based on quay/clair#530