Error handling project and members

[naitmare01]

This PR introduces error-handling to gracefully update and recreate resources that have been altered outside of Terraform.

• project
• project_member_group
• project_member_user

This fixes #235

[flbla]

Hi @naitmare01,
thanks

there is an issue with the SendRequest function : https://github.com/goharbor/terraform-provider-harbor/blob/main/client/client.go#L88
instead of return resp.StatusCode it return 0 when the expected status code is different of the status code.

if we fix that, it will be handle by : https://github.com/goharbor/terraform-provider-harbor/blob/main/provider/resource_project.go#L96 if respCode == 404 && err != nil in the resourceProjectRead function.

same for other resources

[flbla]

we need to fix SendRequest function

[naitmare01]

@flbla I agree that SendRequest needs to be fixed. That explains why I was having trouble getting proper response-code when I wrote this PR.

Are there any active issue or PR coming to fix that? I suggest we wait with this PR until that is fixed.

[flbla]

There is no PR yet. I discovered the bug will reviewing your PR.

[flbla]

@naitmare01 : #363
I did some tests, it seems better.

[naitmare01]

LGTM!

[flbla]

I merged #363
i think we can return nil here : https://github.com/goharbor/terraform-provider-harbor/pull/356/files#diff-8872ceb4daebf7b2223fb0a0341bd06991a1758ec72c38dcf9fc66a396638533R98 to handle it

[naitmare01]

I merged #363 i think we can return nil here : https://github.com/goharbor/terraform-provider-harbor/pull/356/files#diff-8872ceb4daebf7b2223fb0a0341bd06991a1758ec72c38dcf9fc66a396638533R98 to handle it

I think it will work fine. But isn't it more clear if we actually return what the error is about instead of nil?

[flbla]

if we return an error, it will not handle resources deleted outside of terraform
maybe I misunderstood what you want to do ?

[naitmare01]

It was I who misunderstood you. :)

Changed to nil in the latest commit.

[naitmare01]

@flbla are you waiting for any more changes from me?