Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable_content_trust_cosign option (matching api) #372

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

ppa007asr
Copy link
Contributor

We use terraform harbor provider to deploy our harbor resources. The option enable_content_trust_cosign was missing. (which is present in de harbor api)

Pull Request is to get this option into the terraform provider

@ppa007asr ppa007asr requested a review from a team as a code owner September 4, 2023 13:11
@flbla
Copy link
Contributor

flbla commented Sep 18, 2023

Hi,
thank you!
LGTM
could you please fix the DCO : https://github.com/goharbor/terraform-provider-harbor/pull/372/checks?check_run_id=16476743057 ? and I'll merge it. thanks.

@flbla flbla added the enhancement New feature or request label Sep 18, 2023
@ppa007asr
Copy link
Contributor Author

@flbla The DCO has been fixed

@ppa007asr
Copy link
Contributor Author

@flbla Hello Florian, We could really use this PR to be merged. But its waiting for a second reviewer. Could you PM one of the other maintainers to ask if they can check and approve this?

Many thanks in advance

@flbla flbla merged commit 9a99877 into goharbor:main Sep 26, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants