Fix retention_policy.schedule empty state

[dmitry-g]

• Save empty string to the state when no schedule is given

Having a harbor_retention_policy resource with an empty schedule (which matches None schedule in Harbor UI), provider tries to update it on every terraform apply execution:

# harbor_retention_policy.retention_policy[0] will be updated in-place
~ resource "harbor_retention_policy" "retention_policy" {
      id       = "/retentions/1"
    - schedule = "None" -> ""
}

This happens because the state is saved as "None" and desired state is actually an empty string.

"schedule": "None",

With the fix applied terraform stops updating the state on every run:

harbor_retention_policy.retention_policy[0]: Refreshing state... [id=/retentions/1]
No changes. Your infrastructure matches the configuration.

and saves the schedule as an empty string:

"schedule": "",

[flbla]

Hi,
thank you!
LGTM.

could you please fix the DCO : https://github.com/goharbor/terraform-provider-harbor/pull/373/checks?check_run_id=16623349353. thanks.

[dmitry-g]

Hi @flbla, sorry, forgot to add it. Fixed, thank you