Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/oauth2: apply the expires_in value returned by the server to Token.ExpiresIn #748

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

soh335
Copy link

@soh335 soh335 commented Oct 20, 2024

In typical usage, Token.Expiry alone is sufficient. However, the ExpiresIn field was introduced in golang/go#61417. Even when a server returns an expires_in value in
methods like Config.Exchange, only the Expiry field is updated, leaving ExpiresIn unchanged, which can cause confusion.

This change ensures that the ExpiresIn field is properly updated when the server provides an expires_in value.

…ExpiresIn

In typical usage, Token.Expiry alone is sufficient.
However, the ExpiresIn field was introduced in golang/go#61417.
Even when a server returns an expires_in value in
methods like Config.Exchange, only the Expiry field is updated,
leaving ExpiresIn unchanged, which can cause confusion.

This change ensures that the ExpiresIn field is properly updated
when the server provides an expires_in value.
@gopherbot
Copy link
Contributor

This PR (HEAD: 20124de) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/621215.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621215.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matt Hickford:

Patch Set 1: Code-Review+2 Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/621215.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621215.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621215.
After addressing review feedback, remember to publish your drafts!

@@ -50,6 +50,11 @@ type Token struct {
// mechanisms for that TokenSource will not be used.
Expiry time.Time

// ExpiresIn is the OAuth2 wire format "expires_in" field,
// which specifies how many seconds later the token expires,
// relative to an unknown time base approximately around "now".
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make it more clear here what "now" means. Indeed it's the time when the token was fetched.

peick pushed a commit to peick/oauth2 that referenced this pull request Jan 5, 2025
…ExpiresIn

In typical usage, Token.Expiry alone is sufficient.
However, the ExpiresIn field was introduced in golang/go#61417.
Even when a server returns an expires_in value in
methods like Config.Exchange, only the Expiry field is updated,
leaving ExpiresIn unchanged, which can cause confusion.

This change ensures that the ExpiresIn field is properly updated
when the server provides an expires_in value.

merges golang#748 (golang#748)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants