-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/oauth2: apply the expires_in value returned by the server to Token.ExpiresIn #748
base: master
Are you sure you want to change the base?
Conversation
…ExpiresIn In typical usage, Token.Expiry alone is sufficient. However, the ExpiresIn field was introduced in golang/go#61417. Even when a server returns an expires_in value in methods like Config.Exchange, only the Expiry field is updated, leaving ExpiresIn unchanged, which can cause confusion. This change ensures that the ExpiresIn field is properly updated when the server provides an expires_in value.
This PR (HEAD: 20124de) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/621215. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. |
Message from Matt Hickford: Patch Set 1: Code-Review+2 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. |
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. |
@@ -50,6 +50,11 @@ type Token struct { | |||
// mechanisms for that TokenSource will not be used. | |||
Expiry time.Time | |||
|
|||
// ExpiresIn is the OAuth2 wire format "expires_in" field, | |||
// which specifies how many seconds later the token expires, | |||
// relative to an unknown time base approximately around "now". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make it more clear here what "now" means. Indeed it's the time when the token was fetched.
…ExpiresIn In typical usage, Token.Expiry alone is sufficient. However, the ExpiresIn field was introduced in golang/go#61417. Even when a server returns an expires_in value in methods like Config.Exchange, only the Expiry field is updated, leaving ExpiresIn unchanged, which can cause confusion. This change ensures that the ExpiresIn field is properly updated when the server provides an expires_in value. merges golang#748 (golang#748)
In typical usage, Token.Expiry alone is sufficient. However, the ExpiresIn field was introduced in golang/go#61417. Even when a server returns an expires_in value in
methods like Config.Exchange, only the Expiry field is updated, leaving ExpiresIn unchanged, which can cause confusion.
This change ensures that the ExpiresIn field is properly updated when the server provides an expires_in value.