Skip to content

Commit

Permalink
internal/configgen: add approved new gopls counters
Browse files Browse the repository at this point in the history
Fixes golang/go#62248 (gopls/goversion)
Fixes golang/go#62249 (gopls/bug)

Change-Id: Ib88a1f757b632219015b0ec0f930f21be64e4d72
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/528295
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
  • Loading branch information
hyangah committed Sep 14, 2023
1 parent cadf160 commit 46be8a5
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 3 deletions.
11 changes: 11 additions & 0 deletions config/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,17 @@
{
"Name": "gopls/client:{vscode,vscodium,vscode-insiders,code-server,eglot,govim,neovim,coc.nvim,sublimetext,other}",
"Rate": 1
},
{
"Name": "gopls/goversion:{1.16,1.17,1.18,1.19,1.20,1.21,1.22,1.23,1.24,1.25,1.26,1.27,1.28,1.29,1.30}",
"Rate": 1
}
],
"Stacks": [
{
"Name": "gopls/bug",
"Rate": 1,
"Depth": 16
}
]
}
Expand Down
22 changes: 20 additions & 2 deletions internal/configgen/config.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,28 @@
# Note: this is not an approved graph config, but merely demonstrates the
# config generation feature during development.
# Note: this is an approved graph config. This is embedded in the configgen program.
# For the graph config file format, see golang.org/x/telemetry/internal/graphconfig.

title: Editor Distribution
counter: gopls/client:{vscode,vscodium,vscode-insiders,code-server,eglot,govim,neovim,coc.nvim,sublimetext,other}
description: measure editor distribution for gopls users.
type: partition
issue: https://go.dev/issue/61038
issue: https://go.dev/issue/62214 # add vscode-insiders
program: golang.org/x/tools/gopls
version: v0.13.0 # temporarily back-version to demonstrate config generation.
---
title: Go versions in use for gopls views
counter: gopls/goversion:{1.16,1.17,1.18,1.19,1.20,1.21,1.22,1.23,1.24,1.25,1.26,1.27,1.28,1.29,1.30}
description: measure go version usage distribution.
type: partition
issue: https://go.dev/issue/62248
program: golang.org/x/tools/gopls
version: v0.13.0
---
title: Number of bug report calls
counter: gopls/bug
description: count the bugs reported through gopls/internal/bug APIs.
type: stack
issue: https://go.dev/issue/62249
program: golang.org/x/tools/gopls
depth: 16
version: v0.13.0
3 changes: 2 additions & 1 deletion internal/configgen/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
//go:build go1.21

// Package configgen generates the upload config file stored in the config.json
// file of golang.org/x/telemetry/config.
// file of golang.org/x/telemetry/config based on the graphconfig stored in
// config.txt.
package main

import (
Expand Down

0 comments on commit 46be8a5

Please sign in to comment.