This repository has been archived by the owner on Jun 2, 2023. It is now read-only.
Test with issues #33
Open
Test with issues #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci
reviewed
Jun 11, 2018
| a := 1 | ||
| if a != 0 { | ||
| return | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block
| import "log" | ||
|
|
||
| func withIssue() { | ||
| log.Printf("bad format: %s", 1) |
There was a problem hiding this comment.
Printf format %s has arg 1 of wrong type int
| } | ||
|
|
||
| func withAnotherIssue() { | ||
| a := 1 |
There was a problem hiding this comment.
File is not goimports-ed
|
|
||
| import "log" | ||
|
|
||
| func withIssue() { |
| log.Printf("bad format: %s", 1) | ||
| } | ||
|
|
||
| func withAnotherIssue() { |
There was a problem hiding this comment.
withAnotherIssue is unused
golangci
force-pushed
the
test-with-issues
branch
from
c75fb2c to
98222d2
Compare
jirfag
force-pushed
the
master
branch
2 times, most recently
from
e557432 to
93bb034
Compare
jirfag
force-pushed
the
master
branch
4 times, most recently
from
9d4340e to
15c38dd
Compare
golangcibot
reviewed
Nov 25, 2018
| funcs := []func(){} | ||
| for _, v := range []int{1, 2} { | ||
| funcs = append(funcs, func() { | ||
| log.Print(v) |
There was a problem hiding this comment.
Using the variable on range scope v in function literal (from scopelint)
| } | ||
| } | ||
|
|
||
| func testScopeLint() { |
There was a problem hiding this comment.
testScopeLint is unused (deadcode)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.