Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PaliGemma notebook examples for zero-shot object detection and instance segmentation. #11

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

NSTiwari
Copy link
Contributor

Added notebook examples for PaliGemma for zero-shot object detection and instance segmentation on images and videos. Please review, thanks. :)

@jethac
Copy link
Collaborator

jethac commented Jun 27, 2024

Thanks for this, Nitin! I'll take a look now at what you've done.

@jethac jethac self-requested a review June 27, 2024 07:10
@jethac jethac assigned NSTiwari and unassigned jethac Jun 27, 2024
@jethac
Copy link
Collaborator

jethac commented Jun 27, 2024

Hey Nitin, thanks again for your work. Unfortunately the notes in CONTRIBUTING.md envisage you actually uploading your notebooks into this repository, not just linking out to yours - apologies if this wasn't clear.

As to why this is required, it's such that we can make sure everything that Gemma users encounter in the cookbook is known by us to run - if we allow a link out to a notebook somewhere else, we have no visibility into any of that.

If you'd be okay with it, I'd encourage you to please:

  • add sections to your notebooks for how to get Kaggle/HF/etc tokens and set them as Colab secrets
  • add a byline section to your notebooks such that anyone reading them knows that you are the original author (and knows where to find you!)
  • resubmit this PR with your notebooks in it

Best,

Jetha

@NSTiwari
Copy link
Contributor Author

NSTiwari commented Jun 27, 2024

Hi @jethac, I've just made the changes suggested by you.

  • Added a section to my notebooks to configure HF token in Colab Secrets.
  • Added a byline section about me at the top of the notebooks.

Could you please review?

@windmaple
Copy link
Collaborator

Haven't looked at the code in detail, but for the 2 notebooks involving videos, is there any way to add a sample video?

@NSTiwari
Copy link
Contributor Author

NSTiwari commented Jul 8, 2024

Haven't looked at the code in detail, but for the 2 notebooks involving videos, is there any way to add a sample video?

@windmaple: Do you want me to add the original video I used for the demo or any video would do? Also, where do I add these videos? Any specific folder within the repo?

@windmaple
Copy link
Collaborator

windmaple commented Jul 9, 2024

@NSTiwari could you create an 'assets' subfolder in PaliGemma folder and add the video you have? Assuming the vid is not too big (say, a few MB?)

@NSTiwari
Copy link
Contributor Author

NSTiwari commented Jul 9, 2024

@NSTiwari could you create an 'assets' subfolder in PaliGemma folder and add the video you have? Assuming the vid is not too big (say, a few MB?)

@windmaple: I just added a couple of videos as sample. Could you please check?

@windmaple
Copy link
Collaborator

Turns out the videos are too big unfortunately (each >25MB). Let's leave them out for now. Sorry for going back and forth on this.

I'll merge once you remove the vids.

@NSTiwari NSTiwari reopened this Jul 10, 2024
@NSTiwari
Copy link
Contributor Author

Turns out the videos are too big unfortunately (each >25MB). Let's leave them out for now. Sorry for going back and forth on this.

I'll merge once you remove the vids.

Thanks, @windmaple. I just deleted videos. Please check.

@windmaple windmaple merged commit 47a850e into google-gemini:main Jul 10, 2024
2 of 6 checks passed
@NSTiwari NSTiwari deleted the paligemma-nitin branch August 16, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants