Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Probe naked domain and protocols for credential #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BrentDouglas
Copy link

When probing for a registries credential currently only the https
prefixed domain is searched. Some credential services (e.g.
docker-credential-secretservice) do not store the protocol and only
return the credential for the naked domain. This probes the naked
domain, https and http prefixed domain to see if any are stored and
returns the first match.

When probing for a registries credential currently only the https
prefixed domain is searched. Some credential services (e.g.
docker-credential-secretservice) do not store the protocol and only
return the credential for the naked domain. This probes the naked
domain, https and http prefixed domain to see if any are stored and
returns the first match.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@BrentDouglas
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants