Skip to content

Commit

Permalink
Update Dagger to use Android SDK 34.
Browse files Browse the repository at this point in the history
Dagger was using SDK 32, but that is no longer shipped with GitHub Actions by default.

https://github.com/google/dagger/actions/runs/12416363360/job/34664836067

RELNOTES=N/A
PiperOrigin-RevId: 707984837
  • Loading branch information
bcorso authored and Dagger Team committed Dec 19, 2024
1 parent 5e50a92 commit fe9a2f9
Show file tree
Hide file tree
Showing 10 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ javadoc_library(
"//java/dagger/producers:producers-srcs",
"//java/dagger/spi:spi-srcs",
],
android_api_level = 32,
android_api_level = 34,
# TODO(ronshapiro): figure out how to specify the version number for release builds
doctitle = "Dagger Dependency Injection API",
exclude_packages = [
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ attempt to delete the `build/` folder will also delete the bazel `BUILD` files.
[download](https://developer.android.com/studio#command-tools)
and unzip it first.
* Install the necessary components. For example, under Linux, run:
`$ANDROID_HOME/tools/bin/sdkmanager "platforms;android-32" "build-tools;32.0.0"`
`$ANDROID_HOME/tools/bin/sdkmanager "platforms;android-34" "build-tools;34.0.0"`
* If you skip this step, you will see an error similar to
`ERROR: missing input file '@androidsdk//:build-tools/32.0.0/aapt'`.
`ERROR: missing input file '@androidsdk//:build-tools/34.0.0/aapt'`.
* You may also need to run `bazel sync`.
* Run tests with `bazel test <target>`, or `bazel test //...` to run all
tests.
Expand Down
4 changes: 2 additions & 2 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ http_archive(

android_sdk_repository(
name = "androidsdk",
api_level = 32,
build_tools_version = "32.0.0",
api_level = 34,
build_tools_version = "34.0.0",
)

####################################################
Expand Down
4 changes: 2 additions & 2 deletions examples/bazel/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ load(

android_sdk_repository(
name = "androidsdk",
api_level = 32,
build_tools_version = "32.0.0",
api_level = 34,
build_tools_version = "34.0.0",
)

#############################
Expand Down
2 changes: 1 addition & 1 deletion java/dagger/android/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ gen_maven_artifact(
"com.google.dagger:dagger",
"com.google.dagger:dagger-lint-aar",
],
javadoc_android_api_level = 32,
javadoc_android_api_level = 34,
javadoc_root_packages = [
"dagger.android",
],
Expand Down
2 changes: 1 addition & 1 deletion java/dagger/android/support/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ gen_maven_artifact(
"com.google.dagger:dagger",
"com.google.dagger:dagger-android",
],
javadoc_android_api_level = 32,
javadoc_android_api_level = 34,
javadoc_root_packages = [
"dagger.android.support",
],
Expand Down
2 changes: 1 addition & 1 deletion java/dagger/hilt/android/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ gen_maven_artifact(
"com.google.guava:guava",
"javax.annotation:javax.annotation-api",
],
javadoc_android_api_level = 32,
javadoc_android_api_level = 34,
javadoc_exclude_packages = [
"dagger.hilt.android.internal",
],
Expand Down
2 changes: 1 addition & 1 deletion java/dagger/hilt/android/processor/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ gen_maven_artifact(
"net.ltgt.gradle.incap:incap",
"org.jetbrains.kotlin:kotlin-stdlib",
],
javadoc_android_api_level = 32,
javadoc_android_api_level = 34,
javadoc_root_packages = [
# Java 11 javadocs requires non-empty root package so use ".internal" as the root package.
"dagger.hilt.processor.internal",
Expand Down
2 changes: 1 addition & 1 deletion java/dagger/hilt/android/testing/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ gen_maven_artifact(
"com.google.guava:guava",
"javax.annotation:javax.annotation-api",
],
javadoc_android_api_level = 32,
javadoc_android_api_level = 34,
javadoc_exclude_packages = [
"dagger.hilt.internal",
"dagger.hilt.android.internal",
Expand Down
2 changes: 1 addition & 1 deletion java/dagger/hilt/processor/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ gen_maven_artifact(
"net.ltgt.gradle.incap:incap",
"org.jetbrains.kotlin:kotlin-stdlib",
],
javadoc_android_api_level = 32,
javadoc_android_api_level = 34,
javadoc_root_packages = [
# Java 11 javadocs requires non-empty root package so use ".internal" as the root package.
"dagger.hilt.processor.internal",
Expand Down

0 comments on commit fe9a2f9

Please sign in to comment.