Remove private from generated Factory's INSTANCE field. #4547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove private from generated Factory's INSTANCE field.
Fixes #4544
Background: Dagger's generated factory has an optimization to lazy load a singleton instance of the factory when there are no dependencies:
The
private
modifier on theINSTANCE
field is not needed and can add extra overhead as described in #4544. Removing theprivate
modifier is also needed once we start generating Kotlin sources since accessing aprivate
field on a nested class in kotlin source is a kotlinc error.RELNOTES=Fixes #4544: Removes private from InstanceHolder field.