Add advance feature indicators to reflection #6546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aardappel
reviewed
Apr 5, 2021
aardappel
reviewed
Apr 5, 2021
aardappel
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While old schemas are forwards compatible, new features are not backwards compatible with old generators. e.g., AdvancedUnionFeatures, OptionalScalars, etc. This PR defines an enum
AdvancedFeaturewhich is a hint to code generators that the serialized schema contains features that may break some generators. It's the responsibility of the code generator to check if there are unrecognized advanced features and fail accordingly.#6428