Remove the --run_only_passes and replace all uses with appropriate --passes flags
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_596700128
branch
6 times, most recently
from
c880aa3 to
d59f9ec
Compare
copybara-service
bot
force-pushed
the
test_596700128
branch
from
d59f9ec to
ca42d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
--run_only_passesand replace all uses with appropriate--passesflagsIn almost all cases what one wants when using the
--run_only_passesflag was to run a single pass. Using the--passesflag is much clearer. In a small number of cases an actual pipeline is required and in that case the explicit--passespipeline is much nicer and easier to reason about since it doesn't have the implicit embeeding of the standard pipeline.